Skip to content

Add GTNF integration pack index#29

Open
mdheller wants to merge 12 commits intomainfrom
feature/gtnf-capture-pack-20260409
Open

Add GTNF integration pack index#29
mdheller wants to merge 12 commits intomainfrom
feature/gtnf-capture-pack-20260409

Conversation

@mdheller
Copy link
Copy Markdown
Member

@mdheller mdheller commented Apr 9, 2026

No description provided.

@mdheller
Copy link
Copy Markdown
Member Author

mdheller commented Apr 9, 2026

@copilot Please fix checks so we can merge

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29dde8738e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +11 to +15
- `governed_triparty_white_paper.md` — current canonical white paper.
- `asi_snet_integration_manual.md` — implementation-facing ASI / SingularityNET integration manual.
- `gtnf_one_page_external_overview_math.md` — short math-forward external overview.
- `validation/` — validation substrate, runtime protocol, reference model, adversarial fixtures, and scorecards.
- `ibc/` — first Cosmos / IBC Classic build spec, version lock, implementation skeleton, and runtime handoff materials.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point index to files that actually exist

The new “Start here” section lists governed_triparty_white_paper.md, asi_snet_integration_manual.md, gtnf_one_page_external_overview_math.md, validation/, and ibc/, but this commit adds only README.md under docs/vnext/integration/gtnf, so every entry is currently a dead reference for anyone following the index. That makes the integration pack non-navigable and blocks the documented onboarding path until those artifacts are added or the list is explicitly marked as planned.

Useful? React with 👍 / 👎.

Agent-Logs-Url: https://github.com/SocioProphet/TriTRPC/sessions/b9bc64cc-488d-4c7c-a860-e578daea0aa0

Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

@copilot Please fix checks so we can merge

Fixed in commit 3f46f94 — the CI was failing due to cargo fmt --check detecting formatting issues. Ran cargo fmt to reformat the Rust source files and tests.

@mdheller
Copy link
Copy Markdown
Member Author

mdheller commented Apr 9, 2026

@copilot fix failed checks and conflicts

Copilot AI and others added 3 commits April 9, 2026 15:33
… in Go, add mode support to build functions

Agent-Logs-Url: https://github.com/SocioProphet/TriTRPC/sessions/3111b99a-cd04-4ba6-be62-cbc6ca774dee

Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

@copilot fix failed checks and conflicts

Fixed in commits 2fb1ba0 and c597bde. Three root causes were addressed:

  1. Incorrect AEAD tags in all fixture files — the stored tags didn't match AEAD(key=0, nonce=from-file, aad=frame-before-tag). Regenerated all tags using the correct algorithm.

  2. Go TLEB3DecodeLen tail-marker bug — read one byte at a time and silently dropped errors for tail-marker bytes (0xF3–0xF6 require 2 bytes). Fixed to read both bytes and corrected the newOff calculation to offset + len(TritPack(usedTrits)). Added a test TestTLEB3DecodeLenTailMarker to cover this.

  3. mode hardcoded to 0 in build functions — pathB fixtures use mode=1, causing repack round-trip failures. Added build_with_mode (Rust) and BuildEnvelopeWithMode (Go); tests now pass the decoded mode trit through.

make verify (Rust fmt+tests, Go tests, Python AEAD verification) all pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants