a11y: render LDP container contents as <ul>, not a 2-column <table>#204
Open
m5x5 wants to merge 1 commit into
Open
a11y: render LDP container contents as <ul>, not a 2-column <table>#204m5x5 wants to merge 1 commit into
m5x5 wants to merge 1 commit into
Conversation
Every row in a folder listing has the same predicate (ldp:contains), so the markup is a list of resources, not a data table. Screen readers now announce "list, N items" instead of an opaque table. - mainTable: <table class="folderPaneMainTable"> -> <ul class="folder-listing"> with aria-label "Contents of <folder>". Each entry is a <li> wrapping the outliner's object cell (passed elementName='div' so it emits a <div>, not a stray <td> outside any table context). - Package branch (container with index.ttl): host element is a <div class="folderPanePackageContents"> instead of <table> -- rendering is delegated to GotoSubject and no row layout is needed. - CSS: drop .folderPaneMainTable / td / th / .folderPanePredicateCell rules; add .folder-listing / .folder-listing__item rules.
Author
|
I think we could remove the comments I added but besides that it looks good from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ldp:contains), so the markup is a list of resources, not a data table. Screen readers now announce "list, N items" instead of an opaque table.mainTableis now<ul class="folder-listing">witharia-label="Contents of <folder>". Each entry is a<li>wrapping the outliner's object cell (passedelementName='div'so it emits a<div>, not a stray<td>outside any table context).index.ttl): host element is<div class="folderPanePackageContents">instead of<table>— rendering is delegated toGotoSubjectand no row layout is needed..folderPaneMainTable/td/th/.folderPanePredicateCellrules; add.folder-listing/.folder-listing__itemrules.Addresses SolidOS/profile-pane#310.
Coordinated PRs
.app-viewto the page-level<main>landmark<main>to<div><main>from ProfileView and EditProfileView