Skip to content

a11y: promote .app-view to the page-level <main> landmark #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
m5x5 wants to merge 3 commits into
base: post-milestone3m
Choose a base branch
from
+8 −8
Draft

a11y: promote .app-view to the page-level <main> landmark #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e9163b
Promote .app-view to the page-level <main> landmark
m5x5 May 11, 2026
a9b8487
fix the profile pane not showing
m5x5 May 11, 2026
ac00ff4
Fix #MainContent CSS after moving the id to .app-view
m5x5 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/databrowser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@
-->

<!-- Main content area — single visible region at a time -->
<main id="MainContent" role="main" tabindex="-1" aria-live="polite">
<div tabindex="-1" aria-live="polite">
<div class="app-shell">
<aside id="NavMenu" class="app-nav" aria-label="Application menu" hidden>
<div id="NavMenuContent" class="menu-content"></div>
</aside>

<div class="app-view">
<main id="MainContent" class="app-view">
<!--
Outline view: the primary RDF-subject browser.
JS appends property-table <div>s (not <tr>s) here.
Expand Down Expand Up @@ -66,11 +66,11 @@
>
<!-- globalAppTabs appends tab widget here -->
</section>
</div> <!-- .app-view -->
</main> <!-- .app-view -->
</div> <!-- .app-shell -->

<div id="MenuOverlay" class="menu-overlay" hidden aria-hidden="true"></div>
</main>
</div>

<!-- Footer — populated by solid-ui initFooter() -->
<footer id="PageFooter" role="contentinfo">
Expand Down
4 changes: 2 additions & 2 deletions src/styles/mash.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ html, body {

#MainContent {
flex: 1 1 auto;
min-width: 0;
min-height: 0;
overflow-y: auto;
-webkit-overflow-scrolling: touch; /* smooth iOS scroll */
container-type: inline-size; /* enable @container queries */
display: flex;
}

#PageFooter {
Expand All @@ -56,7 +56,7 @@ html, body {
/* ── New responsive app nav layout ── */
.app-shell {
display: flex;
flex: 1; /* expand to fill #MainContent (display:flex row container) */
flex: 1; /* expand to fill .app-shell row */
min-width: 0; /* prevent overflow in flex context */
min-height: calc(100vh - var(--app-header-height) - 2.5rem); /* header + footer space */
margin-top: var(--app-header-height);
Expand Down
2 changes: 1 addition & 1 deletion static/browse-test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
As user <span id="webId">&lt;public user></span>
<span id="loginButtonArea"></span>
</div>
<main id="MainContent" role="main" tabindex="-1" aria-live="polite" class="browser-main">
<main id="MainContent" tabindex="-1" aria-live="polite" class="browser-main">

<table
id="OutlineView"
Expand Down
2 changes: 1 addition & 1 deletion static/browse.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
As user <span id="webId">&lt;public user></span>
<span id="loginButtonArea"></span>
</div>
<main id="MainContent" role="main" tabindex="-1" aria-live="polite" class="browser-main">
<main id="MainContent" tabindex="-1" aria-live="polite" class="browser-main">

<table
id="OutlineView"
Expand Down