a11y: demote tab-widget body from <main> to <div>#747
Open
m5x5 wants to merge 1 commit into
Open
Conversation
The tab widget previously created <main> elements for both its outer body container and per-tab content body. Combined with the shell's own <main>, that meant every tabbed pane view had two or more <main> landmarks per page. The page-level <main> landmark now lives on the shell's `.app-view` in mashlib (see SolidOS/mashlib PR). Tab widget internals become plain <div>s so we have exactly one <main> per page. No styling change: the widget uses `style.tabsMainElement` and `bodyMainStyle` inline, not a `main` selector. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<main>elements for both its outer body container and per-tab body. Combined with the shell's own<main>, each tabbed pane view had two or more<main>landmarks per page.<main>landmark now lives on the shell's.app-view(see a11y: promote .app-view to the page-level <main> landmark mashlib#394). Tab widget internals become plain<div>s so we have exactly one<main>per page.style.tabsMainElementandbodyMainStyleinline, not amainselector.Addresses SolidOS/profile-pane#310.
Coordinated PRs
.app-viewto the page-level<main>landmark (land first)<main>from ProfileView and EditProfileView