This repository was archived by the owner on May 2, 2022. It is now read-only.
Drive trays message queue from existing main loop.#6
Open
dicroce wants to merge 19 commits intoSoundux:masterfrom
Open
Drive trays message queue from existing main loop.#6dicroce wants to merge 19 commits intoSoundux:masterfrom
dicroce wants to merge 19 commits intoSoundux:masterfrom
Conversation
Author
|
This change allows someone to avoid creating a thread just to call tray run()... instead you can just call tray->pump() somewhere in your main loop. |
Fix macOS implementation and build issues
Store getText() result in std::string before calling c_str() to prevent use-after-free of temporary string object.
Fix segfault from dangling pointer in button text handling
Nil out the status item button's image before releasing the status item to prevent the Icon destructor from calling CFRelease on an already-freed NSImage.
Nil out the status item button's image before releasing the status item to prevent the Icon destructor from calling CFRelease on an already-freed NSImage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow trays message queue to be drive from an existing main loop.