Fix/improve flakiness of scs-0101 tests #1064
Merged
+19
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The console output inside the VM is quite easily disrupted by concurrent processes. This makes finding the relevant output quite complicated. The heuristics for this task was not optimal; let's hope this one is better. Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Contributor
Author
|
Successfully tested this on both |
garloff
reviewed
Jan 25, 2026
Member
garloff
left a comment
garloff
left a comment
There was a problem hiding this comment.
I agree on the approach.
Will have to look at the code on a bigger screen for review.
garloff
approved these changes
Jan 25, 2026
Member
garloff
left a comment
garloff
left a comment
There was a problem hiding this comment.
Looks good and should definitely be less prone to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console output inside the VM is quite easily disrupted by concurrent processes. This makes finding the relevant output quite complicated. The heuristics for this task was not optimal; let's hope this one is better.