Skip to content

Add compatibility with NP2020 probes #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrishalcrow wants to merge 4 commits into
base: main
Choose a base branch
from
+130 −4
Open

Add compatibility with NP2020 probes #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4558762
remove int cast of imro header_values
chrishalcrow May 8, 2026
5289f7b
add test data and test for 2020
chrishalcrow May 8, 2026
c40cfdd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 8, 2026
18ed51b
oups - remove prints
chrishalcrow May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/probeinterface/neuropixels_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ def _parse_imro_string(imro_table_string: str, probe_part_number: str) -> dict:
# Parse header fields using the catalogue schema
imro_header_fields_string = probe_features["z_imro_formats"][imro_format + "_hdr_flds"]
imro_header_fields = tuple(imro_header_fields_string.replace("(", "").replace(")", "").split(","))
header_values = tuple(map(int, header_str[1:].split(",")))
header_values = tuple(header_str[1:].split(","))
# Initialize with parsed header and empty lists for per-entry fields (filled below)
imro_per_channel = {"header": dict(zip(imro_header_fields, header_values))}
for field in imro_fields:
Expand Down Expand Up @@ -723,7 +723,7 @@ def read_imro(file_path: str | Path) -> Probe:
imro_str = str(f.read())

imro_table_header_str, *imro_table_values_list, _ = imro_str.strip().split(")")
imro_table_header = tuple(map(int, imro_table_header_str[1:].split(",")))
imro_table_header = tuple(imro_table_header_str[1:].split(","))

if len(imro_table_header) == 3:
# In older versions of neuropixel arrays (phase 3A), imro tables were structured differently.
Expand All @@ -733,7 +733,6 @@ def read_imro(file_path: str | Path) -> Probe:
imDatPrb_type, _ = imro_table_header
else:
raise ValueError(f"read_imro error, the header has a strange length: {imro_table_header}")
imDatPrb_type = str(imDatPrb_type)

for probe_part_number, probe_type in probe_part_number_to_probe_type.items():
if imDatPrb_type == probe_type:
Expand Down Expand Up @@ -908,7 +907,7 @@ def parse_spikeglx_snsGeomMap(meta: dict) -> tuple[int, float, float, np.ndarray
geom_list = meta["snsGeomMap"].split(sep=")")

# first entry is for instance (NP1000,1,0,70)
probe_type, num_shank, shank_pitch, shank_width = geom_list[0][1:].split(",")
_, num_shank, shank_pitch, shank_width = geom_list[0][1:].split(",")
num_shank, shank_pitch, shank_width = int(num_shank), float(shank_pitch), float(shank_width)

geom_list = geom_list[1:-1]
Expand Down
Loading
Loading