Skip to content

Investigate (and fix) VADD CI failure #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 2 commits into from
May 8, 2026
+6 −7
Merged

Investigate (and fix) VADD CI failure #3073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a8536f
reinstate failing test for investigation
mgravell May 8, 2026
c0d1d56
fix CI
mgravell May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ StackExchange.Redis.*.zip
.idea/
.vs/
.vscode/
.codex
*.lock.json
test-results*.xml
packages/
Expand Down
7 changes: 3 additions & 4 deletions tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ public async Task VectorSetAdd_WithAttributes()
[InlineData(VectorSetQuantization.Binary, true)]
public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization, bool useFp32)
{
#if RELEASE // CI runs as Release
Assert.SkipWhen(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), "CI oddness on Windows; needs attention - logged #3072");
#endif
await using var conn = Create(require: RedisFeatures.v8_0_0_M04);
var server = conn.GetServer(RedisKey.Null);
Log($"Server version: {server.Version}");
var db = conn.GetDatabase();
var key = Me() + "/" + quantization;

Expand All @@ -82,7 +81,7 @@ public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization
attributes);
request.UseFp32 = useFp32;
request.Quantization = quantization;
request.ReducedDimensions = 64;
request.ReducedDimensions = 4;
request.BuildExplorationFactor = 300;
request.MaxConnections = 32;
request.UseCheckAndSet = true;
Expand Down
5 changes: 2 additions & 3 deletions tests/StackExchange.Redis.Tests/VectorSetUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace StackExchange.Redis.Tests;

[Collection(NonParallelCollection.Name)] // because of the FP32 suppression
public sealed class VectorSetUnitTests(ITestOutputHelper output)
{
// the aim of this test is to validate that we're sending the right thing - VADD is complex
Expand Down Expand Up @@ -34,7 +33,7 @@ public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization
attributes);
request.UseFp32 = useFp32;
request.Quantization = quantization;
request.ReducedDimensions = 64;
request.ReducedDimensions = 4;
request.BuildExplorationFactor = 300;
request.MaxConnections = 32;
request.UseCheckAndSet = true;
Expand All @@ -56,7 +55,7 @@ public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization
Assert.Equal("VADD", req[0]);
Assert.Equal("mykey", req[1]);
Assert.Equal("REDUCE", req[2]);
Assert.Equal(64, req[3]);
Assert.Equal(4, req[3]);
req = req.Slice(4);

if (useFp32)
Expand Down
Loading