OpenSB Support - register filters always, use flags to control compression loop #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n when protocol stream enables it
rubellyte
requested changes
Oct 24, 2024
Member
rubellyte
left a comment
rubellyte
left a comment
There was a problem hiding this comment.
This seems like a slightly more elegant solution to me. I've tested this myself on Windows in all combinations of vanilla/OSB client/server, don't see any issues. There's a bit of what looks like leftover code, could you take that out? You may have to rebase this or open a new PR or something since I've merged all the previous stuff.
rubellyte
approved these changes
Oct 25, 2024
|
seems to have been broken by an update at some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @rubellyte on #156, this PR builds on that one and hooks up the zstd filters for all connections, but disables the compressor/decompressor by default. When protocol packets are detected indicating zstd support, the filters start compressing and decompressing without need to restart the main server loop. I have tested this briefly with an OSB client and server running the latest version (0.1.6) with no issue, but I have not tested vanilla client/server yet.