Skip to content

Main#6

Open
craigmoyle wants to merge 61 commits into
SteveLane:masterfrom
craigmoyle:main
Open

Main#6
craigmoyle wants to merge 61 commits into
SteveLane:masterfrom
craigmoyle:main

Conversation

@craigmoyle
Copy link
Copy Markdown

No description provided.

Steve Lane and others added 30 commits August 6, 2020 20:39
updated the 2017 data accordingly
add a reactive to seasons etc
# Conflicts:
#	README.md
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Create the initial maintained-fork release, add a changelog since the upstream fork point, and include the package hardening work needed for a clean release build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add downloadFixture() to fetch match schedules for any comp_id
- Add anzc_comp_ids dataset (35 rows, 2008–2025)
- Document ANZ Championship scoring guidance in ladders()
- Update DESCRIPTION, README, and changelog for v0.3.0

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
craigmoyle and others added 30 commits April 7, 2026 08:37
roxygen2's roxygenise() calls pkgload::load_all() which in newer CI
versions validates that documented objects are exported. anzc_comp_ids
is a LazyData dataset and cannot be explicitly exported (causes
'undefined exports' at install time). Fix by passing load_code = NULL
to roxygenise() in CI, which skips the load_all() step while still
regenerating docs correctly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Roxygen2 validates LazyData dataset aliases against exported namespace
symbols, which fails for datasets documented without @export. Since all
.Rd files are committed to the repo, regenerating docs in CI is
unnecessary and causes false failures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace magrittr pipe with native |> throughout; drop magrittr from Imports
- Bump minimum R version to 4.1.0; add dplyr (>= 1.1.0) constraint
- Add guard warning in matchPoints() for missing zone stats
- Fix matchPoints_pre_2020(): remove spurious group_by(squadName) on home data frame
- Fix ladders_pre_2020(): correct old_system param documentation
- Fix matchResults()/matchResults_pre_2020(): remove redundant group_by after nest()
- Update case_when(TRUE ~) to .default = idiom in matchPoints.R
- Consolidate globalVariables() into single call; add missing names
- Remove dead .unUnload hook from zzz.R
- Annotate %||% with @nord
- Fix anzc_comp_ids.Rd: usage data(anzc_comp_ids); add data() call in example
- Fix season_2017 docs: value column is integer not character
- Add Craig Moyle as package author/maintainer in DESCRIPTION
- Remove roxygenise step from CI workflow
- Bump version 0.3.0 -> 0.3.1; update changelog

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependabot config must live at .github/dependabot.yml, not inside
.github/workflows/. The misplaced file was being picked up as a GitHub
Actions workflow and failing on every push.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The dataset was never committed because *.rda was listed in .gitignore.
R package data files in data/ must be tracked in git — removing the rule
so all current and future .rda datasets are committed by default.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add listCompetitions(source) generic backed by .application_source_map
- Add listCompetitionsNetballNZ(), listCompetitionsEnglandNetball(),
  listCompetitionsWorldCup(year) named wrappers
- Add listAllCompetitions() with deduplicate and on_error options
- Refactor internals to generic build/fetch/extract helpers
- Handle World Cup catalogues that omit competition_name (NA)
- Drop competition entries with no id in extractor
- Normalise single-entry catalogues that parse as named list
- Expand test suite: URL builder, source resolver, World Cup format,
  deduplication, partial failure behaviour
- Bump version to 0.5.0, update changelog and README

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants