Make watchdog suppression counter-based for safe nesting#4
Merged
Conversation
Change WatchdogSuppressionGuard from AtomicBool to AtomicUsize so multiple guards can be active simultaneously. The watchdog resumes only when all guards have been dropped (counter reaches 0). This allows placing suppress_watchdog() inside node constructors without worrying about interleaving with test-level suppression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2. Changes
WatchdogSuppressionGuardfromAtomicBooltoAtomicUsizeso multiple guards can be active simultaneously. The watchdog resumes only when all guards have been dropped (counter reaches 0).Motivation
This allows placing
suppress_watchdog()inside node constructors (which are called in loops) without conflicting with a test-level suppression guard. With the bool-based approach, dropping an inner guard would prematurely re-enable the watchdog while the outer guard is still alive.Test plan