mpv: Add support for clipboard property and Wayland#734
Open
BlankEclair wants to merge 1 commit intoSyncplay:masterfrom
Open
mpv: Add support for clipboard property and Wayland#734BlankEclair wants to merge 1 commit intoSyncplay:masterfrom
BlankEclair wants to merge 1 commit intoSyncplay:masterfrom
Conversation
Contributor
|
I just stumbled upon this PR. It's sad to see how much time has passed without any feedback.
Can you clarify what you mean by "pasting"? I am running Wayland and reading the code and testing my older version, the only thing I'm assuming is not working, is when I paste an URL to mpv, it doesn't get added to the syncplay playlist. Every other "pasting" is working for me. It might be good to be more specific in the message. |
Author
|
Opening the chat and doing Ctrl+V to paste text from the clipboard ^^;
|
Contributor
|
Ah you mean the integrated chat in mpv, described here: Enable chat input via mpv. Now it makes sense, sorry. 😅 Yes right now pasting doesn't work for me there. I'll try your version when I can. Thank you for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting currently does not work when on Wayland, which this commit fixes.
mpv 0.40.0 also added support for the clipboard property, so I added support for that as well. I added fallbacks to the CLI versions, but I'm not too interested in getting a copy of mpv 0.23.0 to test it out (especially since the build system seems to rely on Python 2).