fix:Rollback SQLAlchemy session on asyncio cancellation#103
Open
forsakenMystery wants to merge 1 commit intoSyntaxArc:masterfrom
Open
fix:Rollback SQLAlchemy session on asyncio cancellation#103forsakenMystery wants to merge 1 commit intoSyntaxArc:masterfrom
forsakenMystery wants to merge 1 commit intoSyntaxArc:masterfrom
Conversation
Contributor
|
This pull request has been automatically marked as stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change ensures async atomic transactions are safely rolled back when an async task is cancelled (e.g., request cancelled/client disconnect, timeouts, TaskGroup cancellation, shutdown).
asyncio.CancelledError is a BaseException since Python 3.8, so it bypasses except Exception and previously skipped the rollback path, risking leaked/open transactions and pinned connections.
We now explicitly catch cancellation/termination exceptions, run a shielded rollback for DB safety, and re-raise to preserve cancellation semantics. This aligns with known cancellation-hardening patterns used in async SQLAlchemy cleanup paths.
Type of change
Bug fix