Skip to content

Feat: add MAR20191 as mitochondrial reaction of MAR03890#995

Merged
edkerk merged 3 commits intodevelopfrom
Add_mitochondrial_reaction_of_MAR03890
Mar 30, 2026
Merged

Feat: add MAR20191 as mitochondrial reaction of MAR03890#995
edkerk merged 3 commits intodevelopfrom
Add_mitochondrial_reaction_of_MAR03890

Conversation

@JHL-452b
Copy link
Copy Markdown
Collaborator

@JHL-452b JHL-452b commented Apr 19, 2025

Main improvements in this PR:

As proposed in #989 :

  • add MAR20191 as mitochondrial reaction of MAR03890;

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2025

This PR has been automatically tested with GH Actions. Here is the output of the MACAW test:

Starting dead-end test...
- Found 1384 dead-end metabolites.
- Found 1141 reactions incapable of sustaining steady-state fluxes in either direction due to these dead-ends.
- Found 1369 reversible reactions that can only carry steady-state fluxes in a single direction due to dead-ends.
Starting duplicate test...
- Skipping redox duplicates because no redox_pairs and/or proton_ids were provided.
- Found 377 reactions that were some type of duplicate:
- 0 were completely identical to at least one other reaction.
- 13 involve the same metabolites but go in the opposite direction or have the opposite reversibility as at least one other reaction.
- 377 involve the same metabolites but with different coefficients as at least one other reaction.

This and a more detailed output from MACAW are also committed to data/macawResults/.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk changed the title Feat: add MAR20189 as mitochondrial reaction of MAR03890 Feat: add MAR20191 as mitochondrial reaction of MAR03890 Mar 30, 2026
…reaction_of_MAR03890

# Conflicts:
#	data/testResults/README.md
#	data/testResults/macaw_results.csv
#	model/reactions.tsv
@edkerk edkerk merged commit a52a5d9 into develop Mar 30, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants