Conversation
When the selected file's format doesn't match the DAW-linked file's format, attempt conversion using JUCE's AudioFormatManager rather than showing an error. Supports WAV, AIFF (.aif/.aiff), and FLAC.
When the selected file's format doesn't match the DAW-linked file's format, attempt conversion using JUCE's AudioFormatManager rather than showing an error. Supports WAV, AIFF (.aif/.aiff), and FLAC.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the TODO at line 289 of
MediaClipboardWidget.h.Previously, attempting to send a file to a DAW-linked track of a
different format would show a "File Type Mismatch" error with no
recovery path. This change attempts format conversion using JUCE's
built-in
AudioFormatManagerbefore falling back to the error dialog.Supported conversions
Implementation notes
already linked in CMakeLists.txt
original to avoid corrupting the DAW file on failure