You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR Review: upgrade azure speech sdk version in azure asr
Overall: This is a straightforward dependency upgrade. The change is small and well-scoped. A few minor observations:
Version jump spans 3 minor releases (1.45.0 to 1.48.2)
Upgrading across three minor versions can occasionally bring behavioral changes in speech recognition, audio handling, or event callbacks. It would be helpful to note in the PR description what prompted the upgrade (bug fix, new feature, security patch, etc.).
PR commit type label
The title uses feat: prefix, but a dependency version bump is more conventionally labeled chore: or build:. Not blocking, just a consistency note.
Missing newline at end of requirements.txt
The diff shows the missing trailing newline is preserved in the updated file. Since requirements.txt is being touched in this PR, it would be clean to add a newline after the last line (aiofiles).
No test evidence
The PR does not reference any test results confirming the upgraded SDK behaves correctly. Given the jump spans multiple minor versions, a note confirming the ASR guarder tests pass would add confidence (task asr-guarder-test EXTENSION=azure_asr_python CONFIG_DIR=tests/configs).
Summary: The manifest version bump (0.2.7 to 0.2.8) is appropriate. No code logic changes are introduced, limiting the risk. Please confirm the SDK upgrade has been tested and note in the PR description why the upgrade was needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.