Conversation
Collaborator
Author
|
This PR will also require alliedmodders/hl2sdk-manifests#4 to land before we can actually merge. |
Add missing SDK_OnMetamodCreateInterface definition
Don't omit frame pointer
- In x64, there's a tendency for jmp calls to be used to go to another function instead of using call. There's probably some stack fuckery going on here since call pushes the return address on the stack. However, since we don't need to use the stack, we can substitute this with a simple jmp reg call instead, which also fixes the crash.
Untested, but probably correct Add more comments on getting sigs
Replace sig with Studio_Duration signature Fetch m_flPoseParameter array member
Add source studio.cpp
Collaborator
Author
|
Leaving a public note here. The PR is still on our radar however we're waiting on the (hopefully positive) resolution of the sourcepawn's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hl2sdk-manifestsrepositoryPtrToPawnAddressshould have been used--targets x86,x86_64to the CI scriptTO-DO :
IEntityDataMapInputFuncDelegate::Alloc