Skip to content

Fix PYTHONBUFFERED typo to PYTHONUNBUFFERED=1#1967

Open
Chasing1020 wants to merge 2 commits into
THUDM:mainfrom
Chasing1020:fix/pythonunbuffered-typo
Open

Fix PYTHONBUFFERED typo to PYTHONUNBUFFERED=1#1967
Chasing1020 wants to merge 2 commits into
THUDM:mainfrom
Chasing1020:fix/pythonunbuffered-typo

Conversation

@Chasing1020
Copy link
Copy Markdown

@Chasing1020 Chasing1020 commented May 27, 2026

ref: #1966 The intended env var to disable Python stdout/stderr buffering is PYTHONUNBUFFERED, not PYTHONBUFFERED. The misspelled variable had no effect, so Ray/training stdout was still subject to buffering.

The intended env var to disable Python stdout/stderr buffering is
PYTHONUNBUFFERED, not PYTHONBUFFERED. The misspelled variable had no
effect, so Ray/training stdout was still subject to buffering.
Copilot AI review requested due to automatic review settings May 27, 2026 13:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes a typo across the codebase where the environment variable PYTHONBUFFERED=16 (a non-existent/invalid variable) was being set instead of the correct PYTHONUNBUFFERED=1, which is the standard Python environment variable for disabling stdout/stderr buffering.

Changes:

  • Replaces export PYTHONBUFFERED=16 with export PYTHONUNBUFFERED=1 across all shell scripts.
  • Applies the same fix to two exec_command calls in slime/utils/external_utils/command_utils.py.
  • Updates the NPU patch file and AMD tutorial documentation with the corrected variable name.

Reviewed changes

Copilot reviewed 48 out of 48 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_gspo.sh Corrects env var name to PYTHONUNBUFFERED=1
slime_plugins/rollout_buffer/rollout_buffer_example.sh Corrects env var name
slime/utils/external_utils/command_utils.py Fixes two exec_command export strings
scripts/run-*.sh (many) Corrects env var across run scripts
scripts/low_precision/run-*.sh Corrects env var in low precision scripts
examples/**/*.sh Corrects env var across example scripts
docs/en/platform_support/amd_tutorial.md Corrects env var in tutorial doc
docker/npu_patch/slime.patch Updates patch file with corrected env var

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/low_precision/run-qwen3-30B-A3B-int4.sh Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants