Open
Conversation
maxxkia
force-pushed
the
cleanup-obsolete-frozen-rules
branch
2 times, most recently
from
7f8a0bf to
099f636
Compare
maxxkia
force-pushed
the
cleanup-obsolete-frozen-rules
branch
from
099f636 to
3a463d1
Compare
* clean up of frozen rules in `stored.rules` where the corresponding file does not exist in the store directory * clean up of files in store directory which are not referenced in `stored.rules` file Both of the above operations are enabled using `default.allowStoreUpdate` property. If `default.allowStoreUpdate=false` and obsolete entries or files are found by either of the above operations, the operation fails with an `StoreUpdateFailedException`. Signed-off-by: Masoud Kiaeeha <6916434+maxxkia@users.noreply.github.com> Resolves TNG#1264
maxxkia
force-pushed
the
cleanup-obsolete-frozen-rules
branch
from
3a463d1 to
b0631bc
Compare
maxxkia
commented
Jan 30, 2025
| .filter(Predicates.not(ruleFiles::contains)) | ||
| .collect(toList()); | ||
|
|
||
| if (!danglingFiles.isEmpty() && !storeUpdateAllowed) { |
Author
There was a problem hiding this comment.
for controlling the new features we can either reuse storeUpdateAllowed property (current implementation) or a new property. reusing the existing property would make this change not backward compatible and is probably not favored. But first I'd like to hear feedback from the maintainers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes bring 2 features
stored.ruleswhere the corresponding file does not exist in the store directorystored.rulesfileBoth of the above operations are enabled using
default.allowStoreUpdateproperty. Ifdefault.allowStoreUpdate=falseand obsolete entries or files are found by either of the above operations, the operation fails with anStoreUpdateFailedException.Signed-off-by: Masoud Kiaeeha 6916434+maxxkia@users.noreply.github.com
Resolves #1264