Conversation
|
Hey @hankem & @codecholeric, Thank you very much for this adaptation. Can you estimate when this PR will be reviewed? |
Member
Author
|
I'm sorry @stefan-heilig-mw; I missed your message! 🙈 Just FYI: I think that the changes only affect the build internally; ArchUnit 1.4.1 already supports JDK 25 (#1440). |
|
Thank you for your reply. We have managed to get it working since then. There was an error in our setup, which initially pointed to ArchUnit. |
as JDK 25 will add a call to `java.util.Objects.requireNonNull` in the constructor of inner classes, cf. https://inside.java/2025/04/04/quality-heads-up/ and https://bugs.openjdk.org/browse/JDK-8351274 . Signed-off-by: Manfred Hanke <manfred.hanke@tngtech.com>
Signed-off-by: Manfred Hanke <manfred.hanke@tngtech.com>
cf. * https://docs.gradle.org/9.0.0/release-notes.html * https://docs.gradle.org/9.1.0/release-notes.html (which supports Java 25) * https://docs.gradle.org/9.2.0/release-notes.html * https://docs.gradle.org/9.3.0/release-notes.html Signed-off-by: Manfred Hanke <manfred.hanke@tngtech.com>
Signed-off-by: Manfred Hanke <manfred.hanke@tngtech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Gradle Wrapper from 8.14.3 to 9.3.1
Release notes:
Also run tests with JDK 25
Release notes: