Skip to content

[TASK] Add XLIFF linting to runTests.sh#2014

Merged
oliverklee merged 1 commit intomainfrom
lintXliff
Mar 28, 2026
Merged

[TASK] Add XLIFF linting to runTests.sh#2014
oliverklee merged 1 commit intomainfrom
lintXliff

Conversation

@AnReiter
Copy link
Copy Markdown
Contributor

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 26, 2026

Pull Request Test Coverage Report for Build 23683581256

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.898%

Totals Coverage Status
Change from base Build 23683023724: 0.0%
Covered Lines: 132
Relevant Lines: 294

💛 - Coveralls

@cumuru
Copy link
Copy Markdown
Contributor

cumuru commented Mar 26, 2026

In #1750 we decided moving away from composer scripts. It would be great to start this on directly without wrapping around the composer call.

@oliverklee oliverklee moved this from Todo to In Review in Best Practices code sprint Mar 27, 2026
@oliverklee oliverklee requested a review from a team March 27, 2026 10:08
@oliverklee oliverklee moved this from In Review to In Progress in Best Practices code sprint Mar 27, 2026
Copy link
Copy Markdown
Contributor

@heiko-hardt heiko-hardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit looks good :)
Please add the function to the list of help arguments (under the help options -s ...)

@AnReiter AnReiter marked this pull request as draft March 27, 2026 10:54
@AnReiter AnReiter force-pushed the lintXliff branch 3 times, most recently from 628d012 to 472b65b Compare March 27, 2026 11:32
@AnReiter AnReiter moved this from In Progress to In Review in Best Practices code sprint Mar 27, 2026
@DanielSiepmann DanielSiepmann marked this pull request as ready for review March 27, 2026 11:46
@DanielSiepmann DanielSiepmann moved this from In Review to In Progress in Best Practices code sprint Mar 27, 2026
@AnReiter AnReiter force-pushed the lintXliff branch 3 times, most recently from 776bcec to bdaf26b Compare March 27, 2026 12:13
@AnReiter AnReiter moved this from In Progress to In Review in Best Practices code sprint Mar 27, 2026
@github-project-automation github-project-automation bot moved this from In Review to In Progress in Best Practices code sprint Mar 27, 2026
@AnReiter AnReiter force-pushed the lintXliff branch 3 times, most recently from cdc082a to 31f746f Compare March 27, 2026 14:36
@AnReiter AnReiter moved this from In Progress to In Review in Best Practices code sprint Mar 27, 2026
@AnReiter AnReiter requested a review from oliverklee March 27, 2026 14:37
@heiko-hardt heiko-hardt self-requested a review March 27, 2026 14:57
Copy link
Copy Markdown
Contributor

@heiko-hardt heiko-hardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please praefix --name with "lintxliff-${...}" (not cgl-${...})
Please add "--rm" attribute for cleanup

check for details: https://docs.docker.com/reference/cli/docker/container/run/#rm

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Best Practices code sprint Mar 27, 2026
@AnReiter
Copy link
Copy Markdown
Contributor Author

When i run Build/Scripts/runTests.sh -s lintXliff,

then when i have used --rm in the code, the terminal says: "The "--rm" option does not exist."

Copy link
Copy Markdown
Contributor

@heiko-hardt heiko-hardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine ;)

@heiko-hardt
Copy link
Copy Markdown
Contributor

When i run Build/Scripts/runTests.sh -s lintXliff,

then when i have used --rm in the code, the terminal says: "The "--rm" option does not exist."

I'm verry sorry, this option is already set in $CONTAINER_COMMON_PARAMS

@AnReiter AnReiter requested a review from heiko-hardt March 28, 2026 09:54
@AnReiter AnReiter moved this from In Progress to In Review in Best Practices code sprint Mar 28, 2026
@github-project-automation github-project-automation bot moved this from In Review to In Progress in Best Practices code sprint Mar 28, 2026
@AnReiter AnReiter moved this from In Progress to In Review in Best Practices code sprint Mar 28, 2026
@AnReiter AnReiter requested a review from a team March 28, 2026 10:52
@oliverklee oliverklee changed the title [TASK] Add Xliff linting to runTests.sh [TASK] Add XLIFF linting to runTests.sh Mar 28, 2026
@oliverklee oliverklee merged commit 713e735 into main Mar 28, 2026
41 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Best Practices code sprint Mar 28, 2026
@oliverklee oliverklee deleted the lintXliff branch March 28, 2026 11:29
AnReiter added a commit that referenced this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

6 participants