Skip to content

[TASK] Add Rector to runTests.sh#2015

Merged
oliverklee merged 1 commit intomainfrom
rector
Mar 27, 2026
Merged

[TASK] Add Rector to runTests.sh#2015
oliverklee merged 1 commit intomainfrom
rector

Conversation

@AnReiter
Copy link
Copy Markdown
Contributor

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 26, 2026

Pull Request Test Coverage Report for Build 23645482693

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 23644657901: 0.0%
Covered Lines: 111
Relevant Lines: 111

💛 - Coveralls

@cumuru
Copy link
Copy Markdown
Contributor

cumuru commented Mar 26, 2026

In #1750 we decided moving away from composer scripts. It would be great to start this on directly without wrapping around the composer call.

@AnReiter AnReiter marked this pull request as draft March 27, 2026 10:22
@AnReiter AnReiter force-pushed the rector branch 2 times, most recently from 77c287d to 10d14da Compare March 27, 2026 10:38
@AnReiter AnReiter moved this from Todo to In Review in Best Practices code sprint Mar 27, 2026
@AnReiter AnReiter requested a review from oliverklee March 27, 2026 10:40
@AnReiter AnReiter marked this pull request as ready for review March 27, 2026 10:52
@oliverklee oliverklee changed the title [TASK] Add rector to runTests.sh [TASK] Add Rector to runTests.sh Mar 27, 2026
@github-project-automation github-project-automation bot moved this from In Review to In Progress in Best Practices code sprint Mar 27, 2026
@AnReiter AnReiter requested a review from oliverklee March 27, 2026 11:51
@AnReiter AnReiter moved this from In Progress to In Review in Best Practices code sprint Mar 27, 2026
@github-project-automation github-project-automation bot moved this from In Review to In Progress in Best Practices code sprint Mar 27, 2026
@AnReiter AnReiter requested a review from oliverklee March 27, 2026 12:04
@AnReiter AnReiter moved this from In Progress to In Review in Best Practices code sprint Mar 27, 2026
Copy link
Copy Markdown
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oliverklee oliverklee enabled auto-merge (squash) March 27, 2026 12:09
@oliverklee oliverklee merged commit abe68bc into main Mar 27, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants