Devicetree DTS and YAML format improvements#491
Devicetree DTS and YAML format improvements#491KenVanHoeylandt wants to merge 10 commits intomainfrom
Conversation
📝 WalkthroughWalkthroughThis pull request introduces a custom DevicetreeException type and adds support for default values on binding properties throughout the DevicetreeCompiler. Changes include replacing generic exceptions with the custom type across multiple modules, adding a 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
Buildscripts/DevicetreeCompiler/source/exception.py (1)
1-3: The__init__override is redundant.
Exception.__init__already handles the message argument, so the constructor just duplicates built-in behavior. You could simplify topassas the body, though this is purely a nit.Suggested simplification
class DevicetreeException(Exception): - def __init__(self, message): - super().__init__(message) + passBuildscripts/DevicetreeCompiler/source/generator.py (1)
86-92: Consider extracting system property names into a constant.Minor nit:
"compatible"appears as a filter on line 90 and again on line 96. A shared constant (e.g.,SYSTEM_PROPERTIES = {"compatible"}) would keep these in sync.
Summary by CodeRabbit
Release Notes
New Features
Improvements
Platform Bindings Updates