Conversation
PR Review: Add new players chartOverall this is clean work - the component decomposition is solid, the SWR pattern is consistent with the codebase, and the 🔵 Minor Issues1. No loading indicator in When // BarChartCard.tsx
{!loading && data.length === 0 &&
<p>{emptyMessage}</p>
}
// data.length > 0 check renders chart, but nothing renders during initial loadConsider adding a loading state (skeleton or spinner) so the card area does not appear blank during the first fetch. 2. Positive In {(change * 100).toFixed(1)}%A small fix makes it unambiguous: {change > 0 ? `+${(change * 100).toFixed(1)}` : (change * 100).toFixed(1)}%3. No tests for new components
|
49ab594 to
24f65a5
Compare
24f65a5 to
484bbcc
Compare
No description provided.