Skip to content

ci: remove unnecessary config#363

Merged
lachlancollins merged 1 commit intomainfrom
ci-workflow
Mar 17, 2026
Merged

ci: remove unnecessary config#363
lachlancollins merged 1 commit intomainfrom
ci-workflow

Conversation

@lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Mar 17, 2026

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD workflows by removing unnecessary configuration overrides in the autofix workflow, enabling use of default fetch behavior.
    • Simplified the release workflow by streamlining token permissions and environment variable configurations.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2026

⚠️ No Changeset found

Latest commit: d516661

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 09269f77-290b-489e-ad3e-86719d345c0f

📥 Commits

Reviewing files that changed from the base of the PR and between 1d33d64 and d516661.

📒 Files selected for processing (2)
  • .github/workflows/autofix.yml
  • .github/workflows/release.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/release.yml
  • .github/workflows/autofix.yml

📝 Walkthrough

Walkthrough

Removed explicit configuration parameters from GitHub Actions workflows: eliminated fetch-depth: 0 from the autofix workflow checkout and removed explicit issues: write permission and GITHUB_TOKEN environment variable from the release workflow, relying on default behaviors instead.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/autofix.yml, .github/workflows/release.yml
Simplified workflow configurations by removing explicit fetch-depth override and redundant permission/environment variable declarations, allowing default GitHub Actions behavior to take effect.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The workflows now run lean and clean,
No extra fetch or permissions unseen,
We trust the defaults, they work just right,
Simplified configurations, oh what delight!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description follows the template structure but the critical '🎯 Changes' section is completely empty with only a placeholder comment, providing no details about what configuration was removed or why. Fill in the '🎯 Changes' section with specific details about which CI configurations were removed and the rationale for their removal.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'ci: remove unnecessary config' clearly and specifically describes the main change in the pull request: removing unnecessary configuration from CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-workflow
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@lachlancollins lachlancollins marked this pull request as ready for review March 17, 2026 13:08
@github-actions
Copy link
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud
Copy link

nx-cloud bot commented Mar 17, 2026

View your CI Pipeline Execution ↗ for commit d516661

Command Status Duration Result
nx run-many --target=build ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-17 13:11:11 UTC

@nx-cloud
Copy link

nx-cloud bot commented Mar 17, 2026

View your CI Pipeline Execution ↗ for commit d516661

Command Status Duration Result
nx affected --targets=test:sherif,test:docs,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-17 13:09:00 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 17, 2026

npm i https://pkg.pr.new/@tanstack/eslint-config@363
npm i https://pkg.pr.new/@tanstack/publish-config@363
npm i https://pkg.pr.new/@tanstack/typedoc-config@363
npm i https://pkg.pr.new/@tanstack/vite-config@363

commit: d516661

@lachlancollins lachlancollins merged commit 13b2454 into main Mar 17, 2026
10 of 11 checks passed
@lachlancollins lachlancollins deleted the ci-workflow branch March 17, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant