fix(db): live query stuck loading when subquery-in-select inner is cold on-demand#1510
Open
marbemac wants to merge 1 commit intoTanStack:mainfrom
Open
fix(db): live query stuck loading when subquery-in-select inner is cold on-demand#1510marbemac wants to merge 1 commit intoTanStack:mainfrom
marbemac wants to merge 1 commit intoTanStack:mainfrom
Conversation
…ld on-demand A live query whose select contains a subquery against an on-demand collection hung forever when the outer returned zero rows and no other consumer had warmed the inner. The lazy mechanism only fires loadSubset per outer row via a per-row tap, so an empty outer never marked the inner ready, and allCollectionsReady stayed false. Skip lazy aliases (subquery-in-select inner aliases and lazy-join inner aliases) in allCollectionsReady. The live query collection's isLoadingSubset gate still keeps the live query from marking ready while in-flight per-row lazy loads are pending.
More templates
@tanstack/angular-db
@tanstack/browser-db-sqlite-persistence
@tanstack/capacitor-db-sqlite-persistence
@tanstack/cloudflare-durable-objects-db-sqlite-persistence
@tanstack/db
@tanstack/db-ivm
@tanstack/db-sqlite-persistence-core
@tanstack/electric-db-collection
@tanstack/electron-db-sqlite-persistence
@tanstack/expo-db-sqlite-persistence
@tanstack/node-db-sqlite-persistence
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/react-native-db-sqlite-persistence
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/tauri-db-sqlite-persistence
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
A live query whose select contains a subquery against an on-demand collection hung forever when the outer returned zero rows and no other consumer had warmed the inner. The lazy mechanism only fires loadSubset per outer row via a per-row tap, so an empty outer never marked the inner ready, and allCollectionsReady stayed false.
Skip lazy aliases (subquery-in-select inner aliases and lazy-join inner aliases) in allCollectionsReady. The live query collection's isLoadingSubset gate still keeps the live query from marking ready while in-flight per-row lazy loads are pending.
✅ Checklist
pnpm test.🚀 Release Impact