Skip to content

chore: fix side-effect issue caused by constructor trying to connect #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlemTuzlak merged 2 commits into from
Sep 25, 2025
Merged

chore: fix side-effect issue caused by constructor trying to connect #177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb120a
chore: fix side-effect issue caused by constructor trying to connect
AlemTuzlak Sep 25, 2025
2dc62ab
fix
AlemTuzlak Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/event-bus-client/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ export class EventClient<
this.#connected = false
this.#connectIntervalId = null
this.#connectEveryMs = 500

if (typeof CustomEvent !== 'undefined') {
this.#connectFunction()
this.startConnectLoop()
}
}

private startConnectLoop() {
Expand Down Expand Up @@ -188,11 +183,17 @@ export class EventClient<
// wait to connect to the bus
if (!this.#connected) {
this.debugLog('Bus not available, will be pushed as soon as connected')
return this.#queuedEvents.push({
this.#queuedEvents.push({
type: `${this.#pluginId}:${eventSuffix}`,
payload,
pluginId: this.#pluginId,
})
// start connection to event bus
if (typeof CustomEvent !== 'undefined') {
this.#connectFunction()
this.startConnectLoop()
}
return
}
// emit right now
return this.emitEventToBus({
Expand Down
Loading