feat(dev): set Node.js version in devEngines#268
Closed
o-az wants to merge 4 commits intoTanStack:mainfrom
o-az:o-az/set-dev-engines
Closed
feat(dev): set Node.js version in devEngines#268o-az wants to merge 4 commits intoTanStack:mainfrom o-az:o-az/set-dev-engines
devEngines#268o-az wants to merge 4 commits intoTanStack:mainfrom
o-az:o-az/set-dev-engines
Conversation
|
|
View your CI Pipeline Execution ↗ for commit ad24a25
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/devtools
@tanstack/devtools-client
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/vue-devtools
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This PR sets the desired Node.js version in
package.json#devEngineswhich will automatically download the proper version if it's not present in the machine.Currently if someone is using Node.js v25 and they run the repo tests, the tests will fail -- and to fix that they have to manually install / set the proper Node.js version. With this change,
pnpmautomatically handles the correct Node.js version and installs it at the repo scope (so no global Node.js installations are affected).✅ Checklist
pnpm test:pr.🚀 Release Impact