Open
Conversation
🦋 Changeset detectedLatest commit: f9fe2bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit f9fe2bb
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/devtools
@tanstack/devtools-a11y
@tanstack/devtools-client
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/vue-devtools
commit: |
MatthijsKok
approved these changes
Mar 14, 2026
Contributor
MatthijsKok
left a comment
MatthijsKok
left a comment
There was a problem hiding this comment.
Tried this out locally by vendoring into my own project, and was able to build and run normally
📝 WalkthroughWalkthroughUpdates toolchain versions across examples and packages to Vite 8 and related plugin bumps, adds Vite v8 to the peer range for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/devtools-a11y/vite.config.ts (1)
5-11: Keep thesatisfiescheck meaningful.Vite already accepts plugin presets (
Plugin[]) in thepluginsarray and flattens them internally, while TypeScript'ssatisfiesoperator is meant to validate the original expression type without widening it. Castingsolid(...)toanyfirst defeats that benefit, so a real Vite 8 /vite-plugin-solidmismatch gets hidden instead of surfaced. (vite.dev)♻️ Suggested change
- solid({ - ssr: true, - }) as any satisfies Plugin, + solid({ + ssr: true, + }) satisfies Plugin | Plugin[],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/devtools-a11y/vite.config.ts` around lines 5 - 11, The current code casts solid(...) to any before using the TypeScript satisfies operator, which defeats the type-checking; remove the "as any" so the expression uses solid({...}) satisfies Plugin directly (i.e., change "solid({ ssr: true, }) as any satisfies Plugin" to "solid({ ssr: true, }) satisfies Plugin") and if TypeScript then reports a mismatch, fix the plugin type by importing the correct Plugin type or updating the solid plugin types so the real Vite 8 / vite-plugin-solid incompatibility surfaces (look for defineConfig, the plugins array, and the solid(...) call).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/devtools-a11y/vite.config.ts`:
- Around line 5-11: The current code casts solid(...) to any before using the
TypeScript satisfies operator, which defeats the type-checking; remove the "as
any" so the expression uses solid({...}) satisfies Plugin directly (i.e., change
"solid({ ssr: true, }) as any satisfies Plugin" to "solid({ ssr: true, })
satisfies Plugin") and if TypeScript then reports a mismatch, fix the plugin
type by importing the correct Plugin type or updating the solid plugin types so
the real Vite 8 / vite-plugin-solid incompatibility surfaces (look for
defineConfig, the plugins array, and the solid(...) call).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 626de318-07d9-405d-8a5e-8a0510460c0a
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (25)
examples/preact/basic/package.jsonexamples/preact/custom-devtools/package.jsonexamples/react/a11y-devtools/package.jsonexamples/react/a11y-devtools/tsconfig.jsonexamples/react/a11y-devtools/vite.config.tsexamples/react/basic/package.jsonexamples/react/bundling-repro/package.jsonexamples/react/custom-devtools/package.jsonexamples/react/drizzle/package.jsonexamples/react/https/package.jsonexamples/react/start/package.jsonexamples/react/time-travel/package.jsonexamples/solid/a11y-devtools/package.jsonexamples/solid/basic/package.jsonexamples/solid/devtools-ui/package.jsonexamples/vue/basic/package.jsonpackage.jsonpackages/devtools-a11y/package.jsonpackages/devtools-a11y/vite.config.tspackages/devtools-ui/package.jsonpackages/devtools-utils/package.jsonpackages/devtools/package.jsonpackages/preact-devtools/package.jsonpackages/react-devtools/package.jsonpackages/solid-devtools/package.json
✅ Files skipped from review due to trivial changes (2)
- examples/solid/basic/package.json
- packages/devtools-utils/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Vite range to include v8
Summary by CodeRabbit
Chores
Examples