test(form-core): improve mergeForm coverage to 100%#2012
test(form-core): improve mergeForm coverage to 100%#2012Kyujenius wants to merge 3 commits intoTanStack:mainfrom
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 3bd8206
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2012 +/- ##
==========================================
- Coverage 90.35% 90.24% -0.11%
==========================================
Files 38 49 +11
Lines 1752 2010 +258
Branches 444 520 +76
==========================================
+ Hits 1583 1814 +231
- Misses 149 176 +27
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎯 Changes
This PR improves test coverage for
mergeForm.tsfrom 87.09% to 100% by adding comprehensive tests for previously uncovered edge cases.Coverage Improvement
Before:
After:
Type System Note
The
mergeFormtests useas anytype assertion due to FormApi's 12 generic parameters whereTSubmitMetadefaults tonever, creating incompatibility with mergeForm'sanyconstraint. This is a type system limitation only - runtime behavior is correct. In production usage viauseTransform, this receivesAnyFormApiand avoids the issue.✅ Checklist
pnpm test:pr.🚀 Release Impact
This PR only adds tests without modifying any implementation code or public APIs. No changeset is required.