Skip to content

test(query-devtools/Devtools): add test for query details panel auto-close when resizing below min height#10698

Merged
sukvvon merged 5 commits into
mainfrom
test/query-devtools-devtools-resize-handle-min-height-clamp
May 13, 2026
Merged

test(query-devtools/Devtools): add test for query details panel auto-close when resizing below min height#10698
sukvvon merged 5 commits into
mainfrom
test/query-devtools-devtools-resize-handle-min-height-clamp

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented May 12, 2026 •
edited
Loading

🎯 Changes

Adds a test for Devtools.tsx covering the resize handle minHeight clamp branch that resets selectedQueryHash:

  • should close the query details panel when dragging shrinks the panel below the minimum height

When the user drags the resize handle to shrink the panel below the 56px (3.5rem) minimum, the panel is clamped and any open query details panel is auto-closed via setSelectedQueryHash(null). No existing case covered this branch.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026 •
edited
Loading

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@autofix-troubleshooter
Copy link
Copy Markdown

autofix-troubleshooter commented May 12, 2026

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@sukvvon sukvvon self-assigned this May 12, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 12, 2026 •
edited
Loading

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10698

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10698

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@10698

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10698

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10698

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10698

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10698

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10698

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10698

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10698

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10698

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10698

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10698

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10698

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10698

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10698

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10698

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10698

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10698

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10698

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10698

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10698

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10698

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10698

commit: aef940e

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026 •
edited
Loading

size-limit report 📦

Path Size
react full 12.1 KB (0%)
react minimal 9.07 KB (0%)

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 13, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit aef940e

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-13 15:04:46 UTC

@sukvvon sukvvon merged commit 5dce547 into main May 13, 2026
11 of 12 checks passed
@sukvvon sukvvon deleted the test/query-devtools-devtools-resize-handle-min-height-clamp branch May 13, 2026 16:03
@sukvvon sukvvon mentioned this pull request May 13, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

package: query-devtools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sukvvon @autofix-troubleshooter