-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(start): add pre-render params + sitemap #7346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikuscs
wants to merge
12
commits into
TanStack:main
Choose a base branch
from
nikuscs:feat-server-side-params
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5a48214
feat: prerenderParams
nikuscs cb7a05d
ci: apply automated fixes
autofix-ci[bot] 7990d41
fix: address prerender review feedback
nikuscs 6f5afd7
fix: stabilize prerender adapter builds
nikuscs fbbe028
fix: isolate prerender route options bundle
nikuscs 8cd8ffe
fix: harden prerender route options bundling
nikuscs 8efa849
test: assert prerender route options are stripped
nikuscs 75a0364
fix: remove nitro route options special case
nikuscs 1c27261
test: cover sitemap host edge cases
nikuscs f47a2a4
Merge branch 'main' into feat-server-side-params
nikuscs 0c80382
ci: apply automated fixes
autofix-ci[bot] 2cba39a
fix: address prerender route option edge cases
nikuscs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@tanstack/start-client-core': minor | ||
| '@tanstack/start-plugin-core': minor | ||
| '@tanstack/start-server-core': minor | ||
| --- | ||
|
|
||
| Add typed route `prerenderParams` support for generating dynamic prerender pages at build time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
e2e/react-start/basic/src/routes/-prerender-params.server.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import '@tanstack/react-start/server-only' | ||
|
|
||
| export const SERVER_ONLY_PRERENDER_MARKER = | ||
| 'server-only-prerender-marker-should-not-be-in-client' | ||
|
|
||
| export function getServerOnlyPrerenderSlug() { | ||
| return SERVER_ONLY_PRERENDER_MARKER.replace( | ||
| 'server-only-prerender-marker-should-not-be-in-client', | ||
| 'server-only-slug', | ||
| ) | ||
| } |
14 changes: 14 additions & 0 deletions
14
e2e/react-start/basic/src/routes/_layout/_layout-2/prerender-nested.$slug.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { createFileRoute } from '@tanstack/react-router' | ||
|
|
||
| export const Route = createFileRoute( | ||
| '/_layout/_layout-2/prerender-nested/$slug', | ||
| )({ | ||
| prerenderParams: () => [{ params: { slug: 'under-layout' } }], | ||
| component: RouteComponent, | ||
| }) | ||
|
|
||
| function RouteComponent() { | ||
| const params = Route.useParams() | ||
|
|
||
| return <div>Nested prerendered slug: {params.slug}</div> | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.