fix(code-explorer): resolving starting path when not available#376
Merged
KevinVandy merged 4 commits intomainfrom Mar 23, 2025
Merged
fix(code-explorer): resolving starting path when not available#376KevinVandy merged 4 commits intomainfrom
KevinVandy merged 4 commits intomainfrom
Conversation
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SeanCassiere
commented
Mar 22, 2025
| } | ||
| const res = await fetch( | ||
| `https://api.github.com/repos/${repo}/contents/${startingPath}?=${branch}`, | ||
| `https://api.github.com/repos/${repo}/contents/${startingPath}?ref=${branch}`, |
Member
Author
There was a problem hiding this comment.
This is what caused index.tsx to show up even though the actual file in the repo (under the target branch) was index.js.
KevinVandy
approved these changes
Mar 23, 2025
LeCarbonator
pushed a commit
to LeCarbonator/tanstack.com
that referenced
this pull request
Jan 11, 2026
…ack#376) * underlying bug of not passing the branch ref * re-enable dev/prod behaviour * display contents from root but find the starting file * better comments for future adventurers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the code-explorer dying when it couldn't resolve to child directories within the
examplePath.For example, when trying to start fetching the contents for
examples/react/pagination/src, where the leaf/srcdirectory did not exist, the whole application would simply fail.To fix this, the contents will always be fetched from the contents API from the base of the
examplePath(i.e.examples/react/pagination). From there on, once the contents have been fetched, the logic indetermineStartingFilePathwill resolve it to the correct starting file-path to have correct file opened in the explorer.This results in a UI change, where the contents of the file-tree will differ from the existing implementation.
Important
The default opened/"starting file" will remain the same for users.
Old:
New:
