Merged
Conversation
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SeanCassiere
reviewed
Aug 8, 2025
SeanCassiere
approved these changes
Aug 8, 2025
Member
SeanCassiere
left a comment
SeanCassiere
left a comment
There was a problem hiding this comment.
adding the approval to allow merging whenever you want
KyleAMathews
pushed a commit
to KyleAMathews/tanstack.com
that referenced
this pull request
Nov 12, 2025
* fix: raw links * fix: docs default redirect * fix: gray buttons * fix: set hash from its link prop
LeCarbonator
pushed a commit
to LeCarbonator/tanstack.com
that referenced
this pull request
Jan 11, 2026
* fix: raw links * fix: docs default redirect * fix: gray buttons * fix: set hash from its link prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the "get started" links are plain strings, not really typesafe in a tanstack style. This PR addresses it.
Also relative navigation does not infers the
libraryIdon pages where the param is defined, this might be material for an issue on Router though.There are 101 typescript errors and 56 eslint warnings in the repo, I might take on this crusade step by step and get rid of them.