Merged
Conversation
and only add the tracing plugin that needs access to the router later
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe router module reorganizes Sentry initialization into a browser-only block at module load and adjusts the Sentry instrumentation approach. TypeScript module augmentation declarations extend TanStack Router and React Start types with custom route properties and configuration fields. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can use your project's `biome` configuration to improve the quality of JS/TS/CSS/JSON code reviews.Add a configuration file to your project to customize how CodeRabbit runs |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/router.tsx (1)
62-62: Consider using a more specific type instead ofany.Using
anybypasses type checking. Since this appears to be a React component returning renderable content, consider usingReact.ReactNodeorReact.ReactElement.♻️ Suggested type improvement
interface StaticDataRouteOption { baseParent?: boolean - Title?: () => any + Title?: () => React.ReactNode showNavbar?: boolean }You may need to add a React import at the top of the file if not already present via JSX transform:
import type { ReactNode } from 'react'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/router.tsx` at line 62, The Title prop type currently uses `any` (Title?: () => any) which disables type checking; change it to return a React renderable type (e.g. `Title?: () => ReactNode` or `() => ReactElement`) and add a type import (`import type { ReactNode } from 'react'`) at the top if needed; update any usages of the `Title` function to satisfy the new return type.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/router.tsx`:
- Around line 9-22: Sentry is currently initialized with sendDefaultPii: true
which will cause automatic collection of IPs/cookies/PII; update the Sentry.init
call (the Sentry.init block / sendDefaultPii setting) to set sendDefaultPii:
false (or remove the option) and, if you still need to attach user identifiers
selectively, add explicit calls to Sentry.setUser(...) only where consented, and
ensure any server-side IP/PII forwarding is disabled or scrubbed before sending.
---
Nitpick comments:
In `@src/router.tsx`:
- Line 62: The Title prop type currently uses `any` (Title?: () => any) which
disables type checking; change it to return a React renderable type (e.g.
`Title?: () => ReactNode` or `() => ReactElement`) and add a type import
(`import type { ReactNode } from 'react'`) at the top if needed; update any
usages of the `Title` function to satisfy the new return type.
Comment on lines
+9
to
+22
| if (typeof document !== 'undefined') { | ||
| Sentry.init({ | ||
| dsn: 'https://ac4bfc43ff4a892f8dc7053c4a50d92f@o4507236158537728.ingest.us.sentry.io/4507236163649536', | ||
| integrations: [Sentry.replayIntegration()], | ||
| sendDefaultPii: true, | ||
| // Performance Monitoring | ||
| tracesSampleRate: 1.0, // Capture 100% of the transactions | ||
| // Set 'tracePropagationTargets' to control for which URLs distributed tracing should be enabled | ||
| tracePropagationTargets: ['localhost', /^https:\/\/tanstack\.com\//], | ||
| // Session Replay | ||
| replaysSessionSampleRate: 0.1, // This sets the sample rate at 10%. You may want to change it to 100% while in development and then sample at a lower rate in production. | ||
| replaysOnErrorSampleRate: 1.0, // If you're not already sampling the entire session, change the sample rate to 100% when sampling sessions where errors occur. | ||
| }) | ||
| } |
There was a problem hiding this comment.
Privacy/compliance concern with sendDefaultPii: true.
Enabling sendDefaultPii causes Sentry to automatically capture user IP addresses, cookies, and other personally identifiable information. This may conflict with GDPR, CCPA, or other privacy regulations and could require additional disclosure in your privacy policy.
Consider whether this is necessary, or if you can achieve your debugging goals without it.
🛡️ Suggested change to disable PII collection
Sentry.init({
dsn: 'https://ac4bfc43ff4a892f8dc7053c4a50d92f@o4507236158537728.ingest.us.sentry.io/4507236163649536',
integrations: [Sentry.replayIntegration()],
- sendDefaultPii: true,
+ sendDefaultPii: false,
// Performance Monitoring📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if (typeof document !== 'undefined') { | |
| Sentry.init({ | |
| dsn: 'https://ac4bfc43ff4a892f8dc7053c4a50d92f@o4507236158537728.ingest.us.sentry.io/4507236163649536', | |
| integrations: [Sentry.replayIntegration()], | |
| sendDefaultPii: true, | |
| // Performance Monitoring | |
| tracesSampleRate: 1.0, // Capture 100% of the transactions | |
| // Set 'tracePropagationTargets' to control for which URLs distributed tracing should be enabled | |
| tracePropagationTargets: ['localhost', /^https:\/\/tanstack\.com\//], | |
| // Session Replay | |
| replaysSessionSampleRate: 0.1, // This sets the sample rate at 10%. You may want to change it to 100% while in development and then sample at a lower rate in production. | |
| replaysOnErrorSampleRate: 1.0, // If you're not already sampling the entire session, change the sample rate to 100% when sampling sessions where errors occur. | |
| }) | |
| } | |
| if (typeof document !== 'undefined') { | |
| Sentry.init({ | |
| dsn: 'https://ac4bfc43ff4a892f8dc7053c4a50d92f@o4507236158537728.ingest.us.sentry.io/4507236163649536', | |
| integrations: [Sentry.replayIntegration()], | |
| sendDefaultPii: false, | |
| // Performance Monitoring | |
| tracesSampleRate: 1.0, // Capture 100% of the transactions | |
| // Set 'tracePropagationTargets' to control for which URLs distributed tracing should be enabled | |
| tracePropagationTargets: ['localhost', /^https:\/\/tanstack\.com\//], | |
| // Session Replay | |
| replaysSessionSampleRate: 0.1, // This sets the sample rate at 10%. You may want to change it to 100% while in development and then sample at a lower rate in production. | |
| replaysOnErrorSampleRate: 1.0, // If you're not already sampling the entire session, change the sample rate to 100% when sampling sessions where errors occur. | |
| }) | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/router.tsx` around lines 9 - 22, Sentry is currently initialized with
sendDefaultPii: true which will cause automatic collection of IPs/cookies/PII;
update the Sentry.init call (the Sentry.init block / sendDefaultPii setting) to
set sendDefaultPii: false (or remove the option) and, if you still need to
attach user identifiers selectively, add explicit calls to Sentry.setUser(...)
only where consented, and ensure any server-side IP/PII forwarding is disabled
or scrubbed before sending.
LadyBluenotes
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and only add the tracing plugin that needs access to the router later
Summary by CodeRabbit