Skip to content

feat: domain model 테스트 코드 작성 #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
devfeijoa wants to merge 9 commits into
base: release/1.6.0
Choose a base branch
from
Open

feat: domain model 테스트 코드 작성 #798

devfeijoa wants to merge 9 commits into from

Conversation

@devfeijoa
Copy link

@devfeijoa devfeijoa commented Jan 24, 2026 •
edited
Loading

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

  • 테스트에 필요한 라이브러리 의존성 추가
  • domain의 library model의 테스트 코드 작성

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

@devfeijoa devfeijoa requested review from m6z1 and s9hn January 24, 2026 05:29
@devfeijoa devfeijoa self-assigned this Jan 24, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 24, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/790

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

s9hn
s9hn approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@s9hn s9hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

app/build.gradle.kts
Comment on lines +76 to +78
testOptions {
unitTests.isReturnDefaultValues = true
}
Copy link
Member

@s9hn s9hn Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a: 어떤 옵션인가요?

domain/library/build.gradle.kts
dependencies {
implementation(projects.core.common)
implementation(projects.data.library)
testImplementation(libs.junit)
Copy link
Member

@s9hn s9hn Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c: 앞으로 테스트를 어느범위까지 적용시킬 생각이신가요?
범위에 따라 테스트 의존성을 플러그인에 추가해도 좋을 것 같아서요

domain/library/src/test/java/com/into/websoso/domain/library/model/AttractivePointsTest.kt

class AttractivePointsTest {

@Test
Copy link
Member

@s9hn s9hn Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c: 이 아래로 gwt주석이 없는데, 유즈케이스 테스트랑 코드 스타일이 통일되면 좋을 것 같아요 주석이 다 있거나 아예 다 없거나!
개인적으론 유즈케이스에서 gwt로 문단나눠주신게 더 잘 읽혔습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s9hn s9hn s9hn approved these changes

@m6z1 m6z1 Awaiting requested review from m6z1

Assignees

@devfeijoa devfeijoa

Labels

[👸 공주 은영] 🧪 [TEST] 테스트 관련

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devfeijoa @s9hn