Modified the Max Moe sampler (sampleMoeDiStefano.py) and tested that it is correct #1452
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the masses of singles and binary components follow Kroupa, and that the result is identical to the COSMIC code implementation (after the same correction is applied)
ilyamandel
requested changes
Feb 9, 2026
Collaborator
ilyamandel
left a comment
ilyamandel
left a comment
There was a problem hiding this comment.
Thank you, @BalexBalex !
The changes and result look great, but I think the current comments make things more confusing (e.g., # Slope = -1.6 for M1 = 0.5 - 1.0 Msun, when it's really -2.3 in the code and -2.3 is the intended Kroupa value). Can we update the comments and remove the commented out code?
Collaborator
Author
|
Updated it, just left a short note to show where the code was modified! |
ilyamandel
approved these changes
Feb 11, 2026
Collaborator
ilyamandel
left a comment
ilyamandel
left a comment
There was a problem hiding this comment.
Thank you, @BalexBalex ! Looks great!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests done: 1) The masses of singles and binary components follow Kroupa for a 1e6MSun sample, 2) The result is identical to the analogous COSMIC code implementation, 3) The other quantities (M1, q, Porb, ecc) and pairs of such quantities are distributed indistinguishably between the COMPAS and COSMIC versions, 4) Changing MMin in COMPAS correctly truncates the primary mass to be above MMin, without affecting other correlations.
