-
-
Notifications
You must be signed in to change notification settings - Fork 63
Add extensibility with overrides directory #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noneel
wants to merge
35
commits into
TechDufus:main
Choose a base branch
from
noneel:clean-fork
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull 251 commits from upstream while preserving local customizations. Preserved: - Neovim config (custom ai.lua, java.lua, debugging.lua plugins) - Bitwarden integration (bin/dotfiles, git role, zsh vars.secret) - Tmux config (keybindings, sessionx, vim-tmux-navigator) - Starship prompt (kept over upstream's oh-my-bash switch) Adopted from upstream: - New roles: awesomewm, claude, opencode, bun, 1password, jj, sesh - detect_sudo.yml pre-task for robust privilege handling - Modern ansible_facts syntax throughout - Zoxide shell integration in .zshrc - Per-role documentation (CLAUDE.md, README.md) - GitHub Actions: shellcheck, yaml-lint, markdown-lint workflows - Robust zsh installer with sudo fallback Bash role merged carefully: kept oh-my-posh cleanup handler, skipped oh-my-bash installation to preserve starship setup.
Task/resync with upstream
Change methodology to use overrides/ directory to stay in sync
Author
TechDufus
added a commit
that referenced
this pull request
Jan 28, 2026
Introduces a wrapper task that checks for three override levels before
running each role:
- vars: loads overrides/{role}/vars/main.yml to merge/override variables
- files: sets _files_path for file operations
- tasks: replaces role entirely with override tasks
Based on approach from PR #144 but centralized in a single wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
overrides/directory structure for fork maintainers to customize roles without modifying upstream filesansible.cfg,main.yml, and 23 rolesProblem
Maintaining a fork with personal customizations (neovim config, bash aliases, etc.) makes pulling upstream changes painful due to merge conflicts.
Solution
The override infrastructure already exists but the directory was missing. This PR adds:
overrides/
├── README.md # Usage documentation
├── group_vars/
│ ├── .gitkeep
│ └── user.yml.example # Example variable overrides
├── roles/.gitkeep # Per-role file/var overrides
└── custom_roles/.gitkeep # Complete role replacements
Three override levels:
group_vars/user.ymlroles/{role}/files/custom_roles/{role}/Test plan
dotfiles --checkto verify no syntax errorsoverrides/group_vars/user.ymlwith a test variableoverrides/roles/bash/files/