Skip to content

fix(doctor): correct summary count from 2 warnings to 1 after mcp-debug icon change#62

Open
TechNickAI wants to merge 1 commit into
mainfrom
fix/pr-59-warning-count-sweep
Open

fix(doctor): correct summary count from 2 warnings to 1 after mcp-debug icon change#62
TechNickAI wants to merge 1 commit into
mainfrom
fix/pr-59-warning-count-sweep

Conversation

@TechNickAI
Copy link
Copy Markdown
Owner

Summary

Follow-up fix for PR #59 review bot feedback.

After PR #59 changed mcp-debug from ⚠️ to ℹ️, the example summary line still
said 2 warnings ⚠️. Only todo-persist.sh remains as a warning in the example
output, so the correct count is 1 warning.

Change

-1 failure ❌  2 warnings ⚠️  11 passed ✅
+1 failure ❌  1 warning ⚠️  11 passed ✅

Review Bot Feedback Addressed

  • cursor[bot]: "Summary warning count inconsistent after icon change" (Medium)
  • chatgpt-codex-connector[bot]: "Align summary counts with info-level mcp-debug example" (P2)

Both bots correctly identified the mismatch between the example output and the summary tally.

What Was Declined

Nothing — this is the only feedback from PR #59 that warranted a fix.

…ug icon change

The example summary still said '2 warnings ⚠️' after PR #59 changed mcp-debug
from ⚠️ to ℹ️. With only todo-persist.sh remaining as a warning in the example,
the correct count is 1. Fixes bot review feedback on PR #59.

Closes: review-sweep feedback from cursor[bot] and chatgpt-codex-connector[bot]
@TechNickAI TechNickAI added review-sweep Automated review sweep fixes Hex Generated by Hex labels May 19, 2026
@claude
Copy link
Copy Markdown

claude Bot commented May 19, 2026

Review: fix(doctor): correct summary count

Summary: Clean, minimal fix. ✅

What's correct

No concerns

  • Code quality: This is a documentation/example string fix — nothing to misread.
  • Bugs/correctness: The new count (1 warning) is consistent with the example body, where only todo-persist.sh remains at ⚠️ level.
  • Security/performance: N/A for a doc fix.
  • Test coverage: No test needed; this is an illustrative example in command documentation.

LGTM. Good follow-through on the review bot feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hex Generated by Hex review-sweep Automated review sweep fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant