fix(doctor): correct summary count from 2 warnings to 1 after mcp-debug icon change#62
Open
TechNickAI wants to merge 1 commit into
Open
fix(doctor): correct summary count from 2 warnings to 1 after mcp-debug icon change#62TechNickAI wants to merge 1 commit into
TechNickAI wants to merge 1 commit into
Conversation
…ug icon change The example summary still said '2 warnings⚠️ ' after PR #59 changed mcp-debug from⚠️ to ℹ️. With only todo-persist.sh remaining as a warning in the example, the correct count is 1. Fixes bot review feedback on PR #59. Closes: review-sweep feedback from cursor[bot] and chatgpt-codex-connector[bot]
Review: fix(doctor): correct summary countSummary: Clean, minimal fix. ✅ What's correct
No concerns
LGTM. Good follow-through on the review bot feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix for PR #59 review bot feedback.
After PR #59 changed⚠️ to ℹ️, the example summary line still
mcp-debugfromsaid
2 warnings ⚠️. Onlytodo-persist.shremains as a warning in the exampleoutput, so the correct count is
1 warning.Change
Review Bot Feedback Addressed
Both bots correctly identified the mismatch between the example output and the summary tally.
What Was Declined
Nothing — this is the only feedback from PR #59 that warranted a fix.