Skip to content

🐛 Fix review issues from PR #7#9

Merged
TechNickAI merged 1 commit intomainfrom
review-sweep/pr-7-fixes
Mar 23, 2026
Merged

🐛 Fix review issues from PR #7#9
TechNickAI merged 1 commit intomainfrom
review-sweep/pr-7-fixes

Conversation

@TechNickAI
Copy link
Owner

Summary

Follow-up fixes from bot review comments on PR #7 (Design Principles for Builders).

  • Fix PostHog key mismatch — Principles page was sending analytics to a different PostHog project than the rest of the site. Now uses the correct shared key.
  • Fix nav inconsistency — Added missing "Heart-Centered Prompts" link to principles page navigation (desktop + mobile) to match homepage nav structure.
  • Add missing 10th principle to homepage — Homepage preview grid showed 9 of 10 principles; added Ecosystem Thinking card.

Bot comment triage

Bot Issue Outcome
cursor[bot] PostHog key mismatch Fixed
claude[bot] Nav inconsistency Fixed
claude[bot] Homepage missing 10th principle Fixed
claude[bot] Copyright year mismatch Declined (incorrect — all pages consistently show © 2025)
claude[bot] Quick nav has 9 items Declined (incorrect — quick nav has all 10)
claude[bot] CDN without SRI WONTFIX (site-wide, tracked in #8)
claude[bot] Alpine.js floating range Issue created: #8

Test plan

  • Verify principles page PostHog events appear in same project as homepage
  • Check principles page nav matches homepage nav order
  • Count 10 principle cards on homepage preview grid
  • Verify mobile nav on principles page includes Heart-Centered Prompts link

🤖 Generated with Claude Code

- Fix PostHog project key mismatch on principles page (was sending
  analytics to wrong project)
- Add missing "Heart-Centered Prompts" nav link to principles page
  (desktop + mobile) for consistency with homepage
- Add missing 10th principle (Ecosystem Thinking) to homepage preview grid

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@TechNickAI TechNickAI added review-sweep Follow-up fixes from PR review comments Hex Created by Hex labels Mar 21, 2026
@claude
Copy link

claude bot commented Mar 21, 2026

PR Review — Fix review issues from PR #7

This is a clean, focused follow-up that addresses legitimate issues from the previous review. Changes are minimal and surgical — good discipline.

✅ What looks good

PostHog key fix — The analytics key mismatch (phc_2eFCEwUz...phc_hyD2NB...) is the highest-value fix here. Sending analytics to the wrong project silently corrupts behavioral data, so catching and fixing this is important.

Nav consistency — The Heart-Centered Prompts link is correctly added to both desktop and mobile nav, with proper @click="mobileMenuOpen = false" Alpine.js handler on the mobile item. The relative path ../\#heart-centered-prompts is correct from the principles/ directory.

10th principle card — The Ecosystem Thinking card matches the existing grid pattern exactly (emoji, h3, p.text-sm). The grid now correctly shows all 10 principles to match the page copy.

Bot comment triage table — The explicit triage of each bot comment with Outcome column is a good practice. Declining incorrect bot suggestions (copyright year, quick nav count) with a clear reason is the right call.

🔍 Minor observations

Formatting churn — The bulk of the diff (~80%) is HTML reformatted from single-line to multi-line attribute style. This is stylistically consistent within the changed blocks, but it makes the actual logic changes harder to spot during review. Consider whether a formatter config (e.g., Prettier) would help keep this stable so future diffs stay signal-rich.

PostHog key in source — Both keys are now visible in git history. This is common for public analytics keys (PostHog project keys are designed to be public-facing), but worth a note: if the old key (phc_2eFCEwUz...) was for a different PostHog project, that project may still be receiving stray events from cached page loads. Worth verifying the old project is either retired or monitored.

No new issues introduced — Checked for XSS, broken links, or structural regressions. None found.

Summary

The three substantive fixes (analytics key, nav link, missing card) are correct and verified. Ready to merge.

🤖 Reviewed with Claude Code

@TechNickAI TechNickAI merged commit b93dd56 into main Mar 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hex Created by Hex review-sweep Follow-up fixes from PR review comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant