fix(Popup): set default attach property to 'body'#3928
Closed
fix(Popup): set default attach property to 'body'#3928
'body'#3928Conversation
RSS1102
requested review from
HaixingOoO,
NWYLZW,
RylanBot,
ZWkang,
carolin913,
honkinglin and
uyarn
as code owners
RSS1102
changed the title
bodybody
RSS1102
changed the title
body'body'
commit: |
Contributor
|
|
RylanBot
reviewed
Oct 31, 2025
Collaborator
RylanBot
left a comment
RylanBot
left a comment
There was a problem hiding this comment.
defaultProps 是 API 仓生成的吧 (?)...也许要双方同步一下
Collaborator
|
组件应该没默认值，默认值从全局配置取 |
Collaborator
是的，要是给组件default，就走不下去global config |
Collaborator
|
attach 全局配置位置太特殊,放在了顶层 如果是放在 PopupConfig.attach 默认值是body ，组件的attach 不定义默认值，文档默认值是会从PopupConfig.attach取出来 |
Collaborator
|
那这个 PR 关闭吧 |
Collaborator
|
TDesignOteam/tdesign-api#501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
因
useAttach最后兜底的默认值为const defaultAttach = 'body';所以不会对popup的使用产生影响📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单