Open
Conversation
Python 3.14's argparse._expand_help() performs '% params' string
formatting on every help string when rendering help output. If the
help text contains a bare '%' that is not a valid '%(name)s'
specifier (e.g. '100%', URL-encoded '%3A', special-char docs like
'% ^ & *'), a ValueError ('badly formed help string') is raised.
Fix: add _escape_help_string() in argument.py that replaces every
'%' with '%%' before the string is handed to argparse. This causes
argparse's HelpFormatter to render the original '%' characters
correctly, while eliminating the format error.
The two documentation properties that feed help= are updated:
- CustomArgument.documentation
- CLIArgument.documentation
Also reverts the misdirected patches from the previous commit
(try/except wrappers in argparser.py, utils.py, main.py, and the
new compatibility.py module) which did not address the root cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.