feat: add scrollPhysics parameter to TerminalView#220
Open
futpib wants to merge 1 commit intoTerminalStudio:masterfrom
Open
feat: add scrollPhysics parameter to TerminalView#220futpib wants to merge 1 commit intoTerminalStudio:masterfrom
futpib wants to merge 1 commit intoTerminalStudio:masterfrom
Conversation
Allow callers to override the scroll physics of the internal Scrollable widget. This is useful when embedding TerminalView inside other scrollable containers or combining it with pinch-to-zoom gestures, where the internal scroll gesture recognizer would otherwise win the gesture arena. Passing NeverScrollableScrollPhysics() disables the internal scroll handling so the host app can manage scrolling externally via scrollController.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow callers to override the scroll physics of the internal Scrollable widget. This is useful when embedding TerminalView inside other scrollable containers or combining it with pinch-to-zoom gestures, where the internal scroll gesture recognizer would otherwise win the gesture arena. Passing NeverScrollableScrollPhysics() disables the internal scroll handling so the host app can manage scrolling externally via scrollController.