Issue #2136: Use valuePath instead of column header texts for ActionLog in ExcelPackager#2137
Open
jameswsullivan wants to merge 2 commits into
Open
Conversation
jameswsullivan
changed the title
jameswsullivan
changed the title
jameswsullivan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Excel export logic for ActionLog-backed submission list columns to use the column valuePath (e.g., lastAction -> entry / lastAction -> actionDate) instead of comparing on the column header title text, improving reliability across title changes and addressing incorrect “Last Event/Last Action” exports.
Changes:
- Refactored
ExcelPackagerActionLogformatting to branch oncolumn.getValuePath()segments rather thancolumn.getTitle(). - Mapped
lastAction.actionDateto formatted date output andlastAction.entryto the log entry text.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+117
to
120
| String[] actionLogValuePath = column.getValuePath().toArray(new String[column.getValuePath().size()]); | ||
| switch (actionLogValuePath[1]){ | ||
| case "actionDate": | ||
| Calendar actionDate = (Calendar) actionLog.getActionDate(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issues:
I tested with our instances and they showed up the same in Excel exports, but a bit more tests are always welcome.
Thanks.