Fix set_expires_in not accepting non-default Period
#402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
Some time ago, I implemented the
set_expires_inmethod (#322) and forgot to check whether values of typedurationother thansecondscould be passed as arguments.I forgot to add a second parameter to the
Periodtemplate type, so thedurationtype with a non-standardPeriodvalue couldn't be matched with the method signature.This pull request adds the missing template parameter and replaces
secondswithhoursin tests and some examples. Some examples usingsecondsstill remain.