Add Dutch National Flag Algorithm for Sorting Arrays of 0s, 1s, and 2s#13094
Add Dutch National Flag Algorithm for Sorting Arrays of 0s, 1s, and 2s#13094arvinder004 wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
enhancement
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,29 @@ | |||
| def dutch_national_flag(arr): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: dutch_national_flag. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: arr
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
…Python_ho into dutch_national_flag
algorithms-keeper
bot
added
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,29 @@ | |||
| def dutch_national_flag(arr: list[int]) -> list[int]: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/dutch_national_flag.py, please provide doctest for the function dutch_national_flag
algorithms-keeper
bot
removed
the
require tests
|
@darkstar @bit-man @spazm @horstjens sir please review this request and i want to contribute further |
|
@darkstar @bit-man @spazm @horstjens sir please review this request and i want to contribute furthe |
1 participant
Describe your change:
This PR introduces the Dutch National Flag algorithm, which efficiently sorts arrays containing only 0s, 1s, and 2s in a single pass. The implementation uses three pointers to partition the array, achieving O(n) time and O(1) space complexity. This algorithm is useful for problems involving categorical partitioning and enhances the array utilities in the project. Example usage and a clear docstring are included for reference.
Checklist: