Wronskian for second order differential equations#13376
Wronskian for second order differential equations#13376Venkat11Thadi wants to merge 10 commits intoTheAlgorithms:masterfrom
Conversation
added wronskian_second_order_de.py
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/wronskian_second_order_de.py
Outdated
| import math | ||
| import cmath | ||
|
|
||
| def compute_characteristic_roots(a: float, b: float, c: float) -> tuple[complex, complex]: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
There was a problem hiding this comment.
a, b, c are explained to be coefficients.
maths/wronskian_second_order_de.py
Outdated
| return "Distinct Real Roots" | ||
|
|
||
|
|
||
| def compute_wronskian(f, g, f_prime, g_prime, x: float) -> float: |
There was a problem hiding this comment.
Please provide type hint for the parameter: f
Please provide descriptive name for the parameter: f
Please provide type hint for the parameter: g
Please provide descriptive name for the parameter: g
Please provide type hint for the parameter: f_prime
Please provide type hint for the parameter: g_prime
Please provide descriptive name for the parameter: x
| return f"y(x) = C1 * e^({root1:g}x) + C2 * e^({root2:g}x)" | ||
|
|
||
|
|
||
| def analyze_differential_equation(a: float, b: float, c: float) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
There was a problem hiding this comment.
a, b, c are explained to be coefficients.
| print(f"General Solution: {general_solution}") | ||
|
|
||
|
|
||
| def main() -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/wronskian_second_order_de.py, please provide doctest for the function main
There was a problem hiding this comment.
there are no doctests required for main function.
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| import cmath | ||
|
|
||
| def compute_characteristic_roots( | ||
| a: float, b: float, c: float |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
| return "Distinct Real Roots" | ||
|
|
||
|
|
||
| def compute_wronskian( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/wronskian_second_order_de.py, please provide doctest for the function compute_wronskian
| print(f"General Solution: {general_solution}") | ||
|
|
||
|
|
||
| def main() -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/wronskian_second_order_de.py, please provide doctest for the function main
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| def compute_characteristic_roots( | ||
| a: float, b: float, c: float |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
|
|
||
| from typing import Callable | ||
|
|
||
| def compute_wronskian( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/wronskian_second_order_de.py, please provide doctest for the function compute_wronskian
| return f"y(x) = C1 * e^({root1:g}x) + C2 * e^({root2:g}x)" | ||
|
|
||
|
|
||
| def analyze_differential_equation(a: float, b: float, c: float) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
| print(f"General Solution: {general_solution}") | ||
|
|
||
|
|
||
| def main() -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/wronskian_second_order_de.py, please provide doctest for the function main
for more information, see https://pre-commit.ci
|
Closing require_descriptive_names PRs to prepare for Hacktoberfest |
2 participants
Describe your change:
Python script to solve and analyze second-order linear differential equations, including characteristic roots, general solution, and Wronskian computation.
Checklist: