Added strings programs in data structure folder#13407
Added strings programs in data structure folder#13407VeeruYadav45 wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,11 @@ | |||
| def has_unique_chars(s): | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/strings/allunique.py, please provide doctest for the function has_unique_chars
Please provide return type hint for the function: has_unique_chars. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
| @@ -0,0 +1,7 @@ | |||
| from collections import Counter | |||
|
|
|||
| def are_anagrams(s1, s2): | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/strings/anagram.py, please provide doctest for the function are_anagrams
Please provide return type hint for the function: are_anagrams. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: s1
Please provide type hint for the parameter: s2
| @@ -0,0 +1,8 @@ | |||
| def char_frequency(s): | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/strings/frequencyofeachchar.py, please provide doctest for the function char_frequency
Please provide return type hint for the function: char_frequency. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
| @@ -0,0 +1,10 @@ | |||
| def reverse_words(sentence): | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/strings/reverseword.py, please provide doctest for the function reverse_words
Please provide return type hint for the function: reverse_words. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: sentence
for more information, see https://pre-commit.ci
|
Closing require_descriptive_names PRs to prepare for Hacktoberfest |
Describe your change:
i have added 4 string programs:
Checklist: