add --bundle-dir option to web subcommand#650
Open
musjj wants to merge 6 commits intoTheBevyFlock:mainfrom
Open
add --bundle-dir option to web subcommand#650musjj wants to merge 6 commits intoTheBevyFlock:mainfrom
--bundle-dir option to web subcommand#650musjj wants to merge 6 commits intoTheBevyFlock:mainfrom
Conversation
musjj
force-pushed
the
bundle-dir
branch
2 times, most recently
from
addf29a to
ce6b483
Compare
DaAlbrecht
added
A-Web
DaAlbrecht
approved these changes
Oct 21, 2025
Collaborator
DaAlbrecht
left a comment
DaAlbrecht
left a comment
There was a problem hiding this comment.
I'm open to this but do you think this is still needed even if the Bundle path is part of the API?
DaAlbrecht
requested changes
Oct 21, 2025
Collaborator
DaAlbrecht
left a comment
DaAlbrecht
left a comment
There was a problem hiding this comment.
My bad, wanted to just leave some comments, didn't mean to approve already
BD103
added
S-Waiting-on-Author
Member
|
@musjj are you still willing to work on this PR? If not, I can label it so someone else can adopt the work! No pressure either way :) |
Contributor
Author
|
Sorry for the incredibly long delay. But yeah, I'm still very much interested in this! I think this feature is still helpful for reducing the guesswork that comes with copying bundle directories, even if I've addressed the comments above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option for copying a packed web bundle directory to a user-specified directory. This lets you skip any error-prone parsing/guessing when locating the bundle directory, which is usually useful for CI-related tasks.
The behavior is modeled after the unstable
--artifact-diroption fromcargo:--artifact-dir(nee--out-dir) Tracking Issue rust-lang/cargo#6790Fix: #649