My attempt at Flashcards. #196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an overview, features, and installation instructions for the Flashcard app.
Correct installation instructions and add package restore step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at the Flashcard project.
In this project I started feel the weight of not having an automated testing because there is a lot of possible things to do so every few changes I lost a lot of time making sure the project was holding itself, I believe testing will be taught soon and I am looking forward to that.
Also, I took the liberty of using EFcore here because I wanted to have familiarity with grouping with the library, it was quite a challenge to make counting and group by work and the code may not be ideal, if the reviewer happens to have some feedback on that part, I would be glad to hear.
Thanks you for your review and your time :)